Updated uploadclass - Comments

classes/upload.class.php

@@ -11,46 +11,48 @@ class Upload {
     }
 
     private static function generateRandomString($length = 5) {
-        $characters = '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';
-        $charactersLength = strlen($characters);
-        $randomString = '';
+        // Function to generate a random string of 5 chars.
+        $characters = '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ'; // Chars to use
+        $charactersLength = strlen($characters); // Check string length
+        $randomString = ''; // An empty var to store our randomstring
         for ($i = 0; $i < $length; $i++) {
+            // Here we loop until we filled our string with the wanted length.
             $randomString .= $characters[rand(0, $charactersLength - 1)];
         }
-        return $randomString;
+        return $randomString; // Returns our randomstring.
     }
 
     public static function handleUpload($file = false) {
-        $errors = [];
-        $filename = $file['name'];
-        $size = $file['size'];
-        $tempname = $file['tmp_name'];
+        $filename = $file['name']; // Get filename
+        $size = $file['size']; // Gets filesize
+        $tempname = $file['tmp_name']; // Where did php upload our data to?
         $type = $file['type']; // Unused in current state.
         $ext = explode('.', $file['name']); // end() doesnt like us using explode directly.
-        $extension = strtolower(end($ext));
-        $randomname = Upload::generateRandomString();
+        $extension = strtolower(end($ext)); // Get the extension of the file.
+        $randomname = Upload::generateRandomString(); // We give our file a random name - It will be this.
 
-        $cwd = getcwd();
+        $cwd = getcwd(); // Our websites CWD (Current working dir)
         $uploadPath = $cwd . Config::$file_path . $randomname . '.' . $extension;
 
         if (!in_array($extension, Config::$file_types)) {
             // Error! This file does not have an acceptable filetype
-            $errors[] = "Filtype ikke accepteret.";
+            return false; // Return false when upload fails.
         }
 
-        if ($size > 5000000) {
-            // We accept a max size of 5 megabytes. (not 5 mebibytes)
-            $errors[] = "Fil for stor.";
+        if ($size > Config::$file_size) {
+            // Filesize is configured in config, defined in bytes.
+            return false; // Return false when upload fails.
         }
 
         if (empty($errors)) {
             // Do fileupload
-
+            // move_uploaded_file is self-explanatory. We move the file into the correct path.
             $makeUpload = move_uploaded_file($tempname, $uploadPath);
 
             if (!$makeUpload) {
-                $errors[] = "Der opstod en fejl under upload af billedet.";
+                return false; // Return false when upload fails.
             } else {
+                // Return where the image was uploaded to.
                 return Config::$sys_url.'img/uploads/'.$randomname.'.'.$extension;
             }
         }