Updated uploadclass - Now uploads files correctly.

classes/upload.class.php

@@ -6,22 +6,34 @@
 
 class Upload {
 
-    // Acceptable filetypes
-    private $filetypes = ['jpeg', 'jpg', 'png', 'svg', 'gif'];
-
-    private function __construct() {
+    public function __construct() {
         
     }
 
+    private static function generateRandomString($length = 5) {
+        $characters = '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';
+        $charactersLength = strlen($characters);
+        $randomString = '';
+        for ($i = 0; $i < $length; $i++) {
+            $randomString .= $characters[rand(0, $charactersLength - 1)];
+        }
+        return $randomString;
+    }
+
     public static function handleUpload($file = false) {
         $errors = [];
         $filename = $file['name'];
         $size = $file['size'];
-        $tempname = $file['tempname'];
-        $type = $file['type'];
-        $extension = strtolower(end(explode('.', $filename)));
+        $tempname = $file['tmp_name'];
+        $type = $file['type']; // Unused in current state.
+        $ext = explode('.', $file['name']); // end() doesnt like us using explode directly.
+        $extension = strtolower(end($ext));
+        $randomname = Upload::generateRandomString();
 
-        if (!in_array($extension, $this->filetypes)) {
+        $cwd = getcwd();
+        $uploadPath = $cwd . Config::$file_path . $randomname . '.' . $extension;
+
+        if (!in_array($extension, Config::$file_types)) {
             // Error! This file does not have an acceptable filetype
             $errors[] = "Filtype ikke accepteret.";
         }
@@ -33,15 +45,14 @@ class Upload {
 
         if (empty($errors)) {
             // Do fileupload
-            
-            $makeUpload = move_uploaded_file($tempname, Config::$file_path);
-            
+
+            $makeUpload = move_uploaded_file($tempname, $uploadPath);
+
             if (!$makeUpload) {
                 $errors[] = "Der opstod en fejl under upload af billedet.";
             } else {
-                return true;
+                return Config::$sys_url.'img/uploads/'.$randomname.'.'.$extension;
             }
-            
         }
     }